Fix productlink collection provider missing items#18152
Closed
tdgroot wants to merge 2 commits intomagento:2.3-developfrom
Closed
Fix productlink collection provider missing items#18152tdgroot wants to merge 2 commits intomagento:2.3-developfrom
tdgroot wants to merge 2 commits intomagento:2.3-developfrom
Conversation
Contributor
|
Hi @tdgroot. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Contributor
|
Hi @tdgroot , looks like changes related to your PR was merged to 2.3-develop. Please, resolve merge conflicts and check if the issue still present. |
Member
Author
Contributor
|
Nice @tdgroot 👍 , our changes are nearly identical, makes me feel more confident that the solution is a good one 🙂 |
Member
Author
|
@hostep exactly what I was thinking! Magento contribution are great sanity checks for your solutions :). |
Member
Author
|
Fixed in #18207 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix productlink collection provider missing items when some positions are null.
Description
There were several issues with the productlink collection provider.
When several items have the position value of null, the position will get converted to '0'. When sorting, the items get sorted by indexing the items by position value and sort them by a key sort. Multiple '0' values for position, means duplicate indexes.
The same applies with every case where multiple items have the same position value.
Manual testing scenarios
Contribution checklist